Update Happy_Number.js #93
Conversation
| @@ -40,7 +49,7 @@ function checkHappyNumber(n){ | |||
| let strNumber = n.toString(); | |||
| let splitNumber = strNumber.split(""); | |||
| if(splitNumber.length <= 1){ | |||
| return (n <= 1)? true:false; | |||
| return (n === 1 || n === 7)? true:false; | |||
There was a problem hiding this comment.
I don't think we'd need to check for 7 since it's already covered by n===1.
| return (n === 1 || n === 7)? true:false; | |
| return n === 1; |
There was a problem hiding this comment.
Hi,
Thanks for getting back to me, the thing is the first if condition checks whether the array's length is 1 or not,
in this case if the array has only 7 then it would be true, and since it is to return true if n===1 it would return false.
I have added some screenshots for tests please feel free to check them.
-
Not adding check for
n===7
-
Adding checks
There was a problem hiding this comment.
ohhhh true! Nice catch. We need to list all happy numbers that are less than 10.
| @@ -40,7 +49,7 @@ function checkHappyNumber(n){ | |||
| let strNumber = n.toString(); | |||
| let splitNumber = strNumber.split(""); | |||
| if(splitNumber.length <= 1){ | |||
| return (n <= 1)? true:false; | |||
| return (n === 1 || n === 7)? true:false; | |||
There was a problem hiding this comment.
ohhhh true! Nice catch. We need to list all happy numbers that are less than 10.
|
Thank you @Alucard2169 |
|
No problem. |
Added base case check for Happy number problem.
About the fix.
7Is also considered a Happy number, previously the code was checking if the array length is1andnwas1then returntrueelsefalse.